Skip to content

Conversation

@iequidoo
Copy link
Collaborator

@iequidoo iequidoo commented Nov 12, 2025

This is updated #6649 . Actually this is a part of #7130, but independent from #7386, so can be merged earlier.
EDIT: Maybe a separate test would be good, testing this in test_remove_member_bcc() isn't straightforward.

@iequidoo iequidoo marked this pull request as draft November 12, 2025 03:18
@iequidoo iequidoo force-pushed the iequidoo/hide-to-header branch 4 times, most recently from e121baa to 365ccf1 Compare November 12, 2025 07:07
@iequidoo iequidoo marked this pull request as ready for review November 12, 2025 07:18
@iequidoo iequidoo requested review from Hocuri and link2xt November 12, 2025 07:19
@iequidoo
Copy link
Collaborator Author

Not much is broken by this and i'd say that the breakage of chat assignment of partially downloaded messages is rather good (because private replies in groups are more rare than "normal" ones), so this shouldn't cause compatibility issues.

@link2xt
Copy link
Collaborator

link2xt commented Nov 23, 2025

test_remove_member_bcc() is really testing the wrong thing, it was originally testing with unencrypted messages. But this is broken since key-contacts introduction when all the tests got encrypted, so no need to fix it for this PR. I think we don't have tests that look into encrypted payload with a MIME parser.

@iequidoo
Copy link
Collaborator Author

iequidoo commented Nov 24, 2025

test_remove_member_bcc() is really testing the wrong thing, it was originally testing with unencrypted messages. But this is broken since key-contacts introduction when all the tests got encrypted, so no need to fix it for this PR. I think we don't have tests that look into encrypted payload with a MIME parser.

Need to fix it up anyway because it starts failing with this PR. But sure, it doesn't test what is expected, i'll try to create a follow-up PR then.

@iequidoo iequidoo force-pushed the iequidoo/hide-to-header branch from 365ccf1 to 9f404f9 Compare November 24, 2025 05:21
@iequidoo iequidoo merged commit 3637fe6 into main Nov 24, 2025
29 checks passed
@iequidoo iequidoo deleted the iequidoo/hide-to-header branch November 24, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants